[MPlayer-dev-eng] Re: [MPlayer-users] getch2 no longer work

[Artur Skawina]

Artur Skawina wrote:
> 
> > I've restored only getch2.c from archive and everything works fine
> 
> hmm, i can't see any difference here (other than that the old
> version breaks if select is interrupted) and i can't see how
> this could cause problems, unless some other code is at fault.
> 
> I don't use -vo vesa, but you just made me try it for the
> first time and indeed the keyboard does not work. With the
> _old_ getch2.c that is... i'll look at this later today.

just tried -vo vesa w/ and w/o the patch (fifo.c and getch.c)
and i see no difference whatsoever -- in both cases the
only key that works is <enter>.

[when testing remember that the dependencies won't pickup the
 changes automatically and "make clean" does not work as you
 might expect... Hmm, patch for the latter problem attached.]

> Is the flickering osd normal for vesa output?

fwiw -double fixes that, but there's still a small green line near
the top. (i740)

artur
-------------- next part --------------
diff -urNp main/Makefile main-as/Makefile
--- main/Makefile	Tue Nov 20 18:38:52 2001
+++ main-as/Makefile	Tue Nov 20 22:47:08 2001
@@ -199,6 +199,7 @@ uninstall:
 
 clean:
 	rm -f *.o *~ $(OBJS)
+	@for a in $(PARTS); do $(MAKE) -C $$a clean; done
 
 distclean:
 	rm -f *~ $(PRG) $(PRG_FIBMAP) $(PRG_HQ) $(PRG_AVIP) $(PRG_TV) $(OBJS) $(PRG_MENCODER) *.o *.a .depend