[MPlayer-dev-eng] configure2 bugreport

[Arpi]

Hi,

> On Sat, Nov 17, 2001 at 09:34:11PM +0200, Arpi wrote:
> [...]
> > "screen size: 1x1" stuff can be removed, afair nothing uses it.
> > (it was used before we introduce config files)
> SCREEN_SIZE_[XY] is still used in mplayer.c (maybe dead code paths...)
> 
> ./mplayer.c:223:static int screen_size_x=0;//SCREEN_SIZE_X;
> ./mplayer.c:224:static int screen_size_y=0;//SCREEN_SIZE_Y;
> ./mplayer.c:1011:     if(!screen_size_x) screen_size_x=SCREEN_SIZE_X; <<
> ./mplayer.c:1012:     if(!screen_size_y) screen_size_y=SCREEN_SIZE_Y; <<
> ./mplayer.h:49:extern int screen_size_x;//SCREEN_SIZE_X;
> ./mplayer.h:50:extern int screen_size_y;//SCREEN_SIZE_Y;
> 
in 4 of these 6 lines it is commented out.
it is still used as default if -x -y -xy not used.
so, just write these values to config.h:
// default scaling factor/size:
#define SCREEN_SIZE_X 1
#define SCREEN_SIZE_Y 1

> > cosmetics:
> > "Checking for Encrypted DVD support ... -ldvdread"
> > it has nothing with encryption (it depends on how dvdread is compiled).
> > it is required for DVD device access, even for unencrypted disks too.
> I figured that afterwards so:
>   libdvdread which dynamically probes for libdvdcss.so.0
>   css if it's only there
> 
> So pick one among "DVD files handling" or "DVD support" or "DVD
> handling" or <better phrase>...
DVD support: no|libcss|libdvdread


A'rpi / Astral & ESP-team

--
mailto:arpi at thot.banki.hu
http://esp-team.scene.hu