[MPlayer-dev-eng] vo_x11: More than 1 video to play

Uwe Reder Uwe.Reder at 3SOFT.de
Tue Nov 6 09:12:30 CET 2001


On Monday 05 November 2001 18:28, Arpi wrote:

> > -static int X_already_started=0;
>
> you completely removed this check. anyway it isn't requires for mplayer,
> it was inherited from mpeg2dec

It is not only *not required*, it also stops mplayer from playing multiple 
files off the command line. Why? This check makes mplayer leave init() half 
way through if init() was called before, although it always does a full 
uninit() after each file. By removing this check, mplayer does a full init() 
before each video and a full uninit() after each video.

> > -      if ((d_width==0) && (d_height==0))
> > -        { X=image_width; Y=image_height; }
> > -      else
> > -        { X=d_width; Y=d_height; }
>> >        for (i=1; i<modecount; i++)
> > -        if ((vidmodes[i]->hdisplay >= X) && (vidmodes[i]->vdisplay >=
> > Y)) +        if ((vidmodes[i]->hdisplay >= image_width) &&
>
> (vidmodes[i]->vdisplay
>
> but why is this change??? it may break -vm switch.

I looked into the code again. And yes, you're right. The above code shouldn't 
be changed. However, I don't know what it's good for :-(

Thanks,
Uwe



More information about the MPlayer-dev-eng mailing list