[MPlayer-dev-eng] Re: [PATCH] improvements in debian/* (Adam Di Carlo)

[Adam Di Carlo]

Dariusz Pietrzak <dariush at ajax.umcs.lublin.pl> writes:

> Hello,
> 
>  i've applied most of it, but this:
> "
>  * debian/control: remove invalid source recommends
> 
> -Recommends: libsdl1.2-dev
> +Build-Depends: c++-compiler, libglib-dev, libgtk-dev, xlibs-dev,
> libpng2-dev, zlib1g-dev, debhelper (>= 2), libmad0-dev, aalib1-dev,
> libasound1-dev, libsdl1.2-dev

> I don't understand.
> Neither libsdl nor libmad0 are really needed to build mplayer. If anything
> - i would remove dependancy on xlibs-dev etc and don't build gui at all.

That's fine.  You're right that these source depends are not strictly
necessary for a minimal build.

You'll notice I removed:

> -Recommends: libsdl1.2-dev

This field is not allowed in that top section, the source package
description.

> OTOH i haven't checked the gui for a long time, i'll fix that.

Yah, the way configure is invoked in debian/rules turns on the GUI,
and there are other bits of there that assume the GUI was built.  It
might be nice to make that part of the debian build adaptive as well.

> About postinst - it used to be /bin/sh, but I felt bad with it, since it
> was invoking debconf, which was invoking perl.. so decided that since perl
> can do postinst, then there's no reason to run /bin/sh.
>  Since there is cdebconf, this decision no longer makes much sense even to
> me.

Yah, we should go back to /bin/sh.  debhelper snippets require that.

-- 
...Adam Di Carlo..<adam at onshore-devel.com>...<URL:http://www.onshored.com/>